Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5integration #32

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#224

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#224
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • CMakeLists.txt文件中,find_package函数的调用顺序似乎已经更改,需要确认新的依赖查找是否正确。
  • option命令的使用可能改变了用户配置插件的选项行为,需要确认这一改动是否符合预期。
  • if("${QT_VERSION_MAJOR}" STREQUAL "5")elseif("${QT_VERSION_MAJOR}" STREQUAL "6")分支中,set(XDG_ICON_VERSION_MAJOR ...)的调用可能依赖于Qt5XdgIconLoader_VERSION_MAJOR的值,但当前的调用顺序没有反映这种依赖关系。
  • list(APPEND QT_LIBS ...)的调用似乎在添加Qt5::X11Extras,但在其他地方没有看到类似的操作,需要确认这一改动是否必要。
  • pkg_check_modules的调用似乎在查找依赖,但Deps变量在后续代码中没有被使用,需要确认这一改动是否必要。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2024

TAG Bot

New tag: 6.0.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #33

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2024

TAG Bot

New tag: 6.0.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #37

@kegechen kegechen merged commit 1765740 into master Jul 12, 2024
27 of 31 checks passed
@kegechen kegechen deleted the sync-pr-224-nosync branch July 12, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants