Redesign menu@cinnamon.org #13124
Closed
Redesign menu@cinnamon.org #13124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefebvre
force-pushed
the
new-menu
branch
4 times, most recently
from
2478752 to
898fc22
Compare
This helps prevent accidentally triggering another category when moving the mouse from the categories to the application column.
Use a unique class for recent files and favorite files.
Removable ones are already in: - nemo (which pops up when plugged) - removable-drives applet Permanent ones don't need quick-access, are already in nemo sidebar and can be bookmarked.
- Unused code - search-filesystem Very niche and didn't work properly.
reproducible with picom
- Use ES2105 for loops (similar to python) - forEach/filter/map for one-liners
Remove show-applications-icons. Simplify refresh. When refreshing after a change in the prefs, don't be selective, refresh everything. We're not looking for performance here. This actually fixed a bug since favdocs catbutton wasn't refreshed earlier on. Simplify navigation. This was overly complicated. Simplify it with .left/.right/.up/.down attributes.
This used to be an all or nothing preference. Turning it off allowed more focus on the apps but it made the category box tiny and not very good looking. This commit replaces this with subtle symbolic icons. They're small, they're all the same (same icon as for all-applications). The section looks good but doesn't draw the user's attention. This is the new default.
This allows us to remove the bottom bar.
This is important because: - distributions want to be able to fill the menu with a number of favs and places which fit nicely in the default menu size. - Users can have a lot of bookmarks and might not want to see them in the menu, but special dirs are bookmarks, so it's all or nothing.. - Some special dirs are more important than others, based on preference, for instance you might never use Music, but use Downloads all the time, other people don't.. - Just like distributions, users will want to fill their sidebar with places and favs with the right mix and the right number of items which' fits nicely. Having the ability to decide what is shown and what isn't lets them do just that.
I can't manage to fix vfade issues when it's used on multiple scrollviews: - Scrolling the apps leads to the top of sidebar/category scrollviews to shade randomly - Random rendering issues on shade zones when hovering the categories vfade would look nice everywhere but these issues make the menu experience worst, not better. Disable these until we find a proper fix.
Use different class names than the old menu. That way we can update themes with the new style section without having to affect the section for the old menu. This means the theme can be updated for both new and old cinnamon versions, without having to get versioned. If people fork the old menu and bring it to spices, themes will continue to work with it without needing it to get new class names and support.
|
This is all merged manually on master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the awesome work Joseph did earlier: #12586