-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Immich Enhanced app #688
Conversation
Nothing changed on that front as far as I'm aware. You made sure your browser isn't caching anything? I'll try to look at it later today but no promises. |
I dont see any caching, I see the |
also the it seems like the files in I can confirm that after updating the files in both |
@mvdkleijn I got the issue of not being able to test things locally fixed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@sidevesh Not sure why you'd need to edit supportedapps... should not be necessary I believe. |
Trying to add Enhanced app for Immich and I think this implementation would work but I can't test it out locally for the life of me.
I have added / upgraded enhanced apps before and this time I just can't get things to work.
Edit: Got things working locally and resolved issues, this should be good to merge now.
I had to edit
/app/www/storage/app/supportedapps.json
to get updated app.json properties to reflect.Got the idea when I saw linuxserver/Heimdall#1246