Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to noble, add encryption support (master) #84

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Rebase to noble, add encryption support (master) #84

merged 8 commits into from
Nov 29, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented Aug 29, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This will fail until 2.0.9 hits stable.

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team August 29, 2024 16:06
@thespad thespad self-assigned this Aug 29, 2024
@thespad thespad marked this pull request as draft August 29, 2024 16:06
@kenkendk
Copy link

kenkendk commented Sep 4, 2024

FYI: Duplicati removed the auto-assigned settings encryption key in v2.0.9.106, so only version 2.0.9.105 is using a system-derived encryption key.
The change was rolled back after we discovered the device key was not based on sufficiently random data (in many case, it was based on an empty string).

The changes in this PR are thus not required for Duplicati 2.0.9.106+ but increases security by specifying a settings encryption key.

@kenkendk kenkendk mentioned this pull request Sep 4, 2024
Closed
1 task
@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@thespad thespad added work-in-progress Stale exempt and removed no-pr-activity labels Oct 4, 2024
@thespad thespad marked this pull request as ready for review November 29, 2024 15:46
@thespad thespad requested review from a team and removed request for a team November 29, 2024 15:46
@aptalca
Copy link
Member

aptalca commented Nov 29, 2024

Needs arm64 binary name updated as well

@aptalca
Copy link
Member

aptalca commented Nov 29, 2024

Unzip adds a subfolder so we need a mv after

@thespad
Copy link
Member Author

thespad commented Nov 29, 2024

You'd think I'd have noticed these things when I did the PR months ago, as I was mostly copying from the dev branch which is already correct.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duplicati/v2.1.0.2_beta_2024-11-29-pkg-3fd699ab-dev-6394d6112639f012c1cd520257861778157e6012-pr-84/index.html
https://ci-tests.linuxserver.io/lspipepr/duplicati/v2.1.0.2_beta_2024-11-29-pkg-3fd699ab-dev-6394d6112639f012c1cd520257861778157e6012-pr-84/shellcheck-result.xml

Tag Passed
amd64-v2.1.0.2_beta_2024-11-29-pkg-3fd699ab-dev-6394d6112639f012c1cd520257861778157e6012-pr-84 ✅
arm64v8-v2.1.0.2_beta_2024-11-29-pkg-3fd699ab-dev-6394d6112639f012c1cd520257861778157e6012-pr-84 ✅

@thespad thespad merged commit 0f721b1 into master Nov 29, 2024
5 checks passed
@thespad thespad deleted the master-rebase-plus-encryption branch November 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptalca aptalca aptalca approved these changes

Assignees

@thespad thespad

Labels
work-in-progress Stale exempt
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thespad @kenkendk @LinuxServer-CI @aptalca