Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Enable PostgreSQL backend and fix libspatialindex branch name. #59

Closed
wants to merge 1 commit into from

Conversation

stateisbad
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds support for the PostgreSQL storage backend, as well as fixes the libspatialindex primary branch name (it is now main)

Benefits of this PR and context:

The default backend, SQLite, performs well on smaller maps, but on servers where the map is quite large, it begins to slow down considerably. PostgreSQL is fully supported by Minetest, and offers the best performance in such cases.

How Has This Been Tested?

This has been tested by building a local image from this branch and running in a lab environment along side the official postgresql image, both with brand-new worlds as well as using the minetestserver --migrate command to migrate an existing world.

Source / References:

https://wiki.minetest.net/Database_backends

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@stateisbad
Copy link
Author

Not sure what's up with the CI failure, as it's pretty opaque. The changes are minimal, so if the image builds, it should run.

@thespad
Copy link
Member

thespad commented May 12, 2024

It's timing out waiting for the init to complete (which in this case is a successful UDP connection on port 30000).

Seems something has changed either upstream or within Alpine and localhost is resolving to the ipv6 address, but minetest is only bound to the IPv4 interface.

As a temporary fix you can edit etc/s6-overlay/s6-rc.d/svc-minetest/run and change

"nc -zu localhost 30000"

to

"nc -zu 127.0.0.1 30000"

@thespad thespad mentioned this pull request May 12, 2024
1 task
@thespad
Copy link
Member

thespad commented May 13, 2024

Turns out there was a bunch of work required to get the init check working and also some other maintenance that was necessary on the image so I've incorporated your changes into #60 which also addresses the CI issues you were seeing.

@thespad thespad closed this May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants