Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LAN Guidance in readme-vars.yml #26

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

ItsMeRitch
Copy link
Contributor

Resolves #7 for good.

linuxserver.io


  • [ x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Myself and some other users reported issues with the software working out of the box on LAN only. This is resolved by commenting out the proxy_set_header in the nginx config. Adding some clear guidance on this would reduce issues opened and help future users

Benefits of this PR and context:

Increase satisfaction of userbase as more likely to work on simpler setups, eg, local networks without proxy

How Has This Been Tested?

Only Doc Change

Source / References:

Myself and some other users reported issues with the software working out of the box on LAN only. This is resolved by commenting out the proxy_set_header in the nginx config. Adding some clear guidance on this would reduce issues opened and help future users
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/eac78009-pkg-dbaf3db7-dev-4f8a1c88b9ffc7a66759e244f8be01e109c4b759-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/eac78009-pkg-dbaf3db7-dev-4f8a1c88b9ffc7a66759e244f8be01e109c4b759-pr-26/shellcheck-result.xml

Tag Passed
amd64-eac78009-pkg-dbaf3db7-dev-4f8a1c88b9ffc7a66759e244f8be01e109c4b759-pr-26
arm64v8-eac78009-pkg-dbaf3db7-dev-4f8a1c88b9ffc7a66759e244f8be01e109c4b759-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/eac78009-pkg-3a39b043-dev-73603d4093e6b6889a93cb4baf87e94941a621bb-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/eac78009-pkg-3a39b043-dev-73603d4093e6b6889a93cb4baf87e94941a621bb-pr-26/shellcheck-result.xml

Tag Passed
amd64-eac78009-pkg-3a39b043-dev-73603d4093e6b6889a93cb4baf87e94941a621bb-pr-26
arm64v8-eac78009-pkg-3a39b043-dev-73603d4093e6b6889a93cb4baf87e94941a621bb-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/debd13a0-pkg-11bd20aa-dev-a138a7f7bb0b8a020de1eb63a69e2869a9a5721e-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/debd13a0-pkg-11bd20aa-dev-a138a7f7bb0b8a020de1eb63a69e2869a9a5721e-pr-26/shellcheck-result.xml

Tag Passed
amd64-debd13a0-pkg-11bd20aa-dev-a138a7f7bb0b8a020de1eb63a69e2869a9a5721e-pr-26
arm64v8-debd13a0-pkg-11bd20aa-dev-a138a7f7bb0b8a020de1eb63a69e2869a9a5721e-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-ad3d03f5-dev-f55b1387eeac6dc4dc1481c95e95a3990c4e6312-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-ad3d03f5-dev-f55b1387eeac6dc4dc1481c95e95a3990c4e6312-pr-26/shellcheck-result.xml

Tag Passed
amd64-f88d46ed-pkg-ad3d03f5-dev-f55b1387eeac6dc4dc1481c95e95a3990c4e6312-pr-26
arm64v8-f88d46ed-pkg-ad3d03f5-dev-f55b1387eeac6dc4dc1481c95e95a3990c4e6312-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-cf1ff271-dev-747954d7831f42939c7e9074af53a39bde2dc2b1-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-cf1ff271-dev-747954d7831f42939c7e9074af53a39bde2dc2b1-pr-26/shellcheck-result.xml

Tag Passed
amd64-f88d46ed-pkg-cf1ff271-dev-747954d7831f42939c7e9074af53a39bde2dc2b1-pr-26
arm64v8-f88d46ed-pkg-cf1ff271-dev-747954d7831f42939c7e9074af53a39bde2dc2b1-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-d3b18676-dev-ff90d5028f3831c6f5325173c8149389f820d5af-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-d3b18676-dev-ff90d5028f3831c6f5325173c8149389f820d5af-pr-26/shellcheck-result.xml

Tag Passed
amd64-f88d46ed-pkg-d3b18676-dev-ff90d5028f3831c6f5325173c8149389f820d5af-pr-26
arm64v8-f88d46ed-pkg-d3b18676-dev-ff90d5028f3831c6f5325173c8149389f820d5af-pr-26

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-c90b5c62-dev-c8d4b898c7802728e5c199d837c5a049d2019484-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-c90b5c62-dev-c8d4b898c7802728e5c199d837c5a049d2019484-pr-26/shellcheck-result.xml

Tag Passed
amd64-f88d46ed-pkg-c90b5c62-dev-c8d4b898c7802728e5c199d837c5a049d2019484-pr-26
arm64v8-f88d46ed-pkg-c90b5c62-dev-c8d4b898c7802728e5c199d837c5a049d2019484-pr-26

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@thespad thespad self-assigned this Jan 8, 2025
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-089d8eb0-dev-093556a0bae433bd3994753b17198805bf4e91d8-pr-26/index.html
https://ci-tests.linuxserver.io/lspipepr/snapdrop/f88d46ed-pkg-089d8eb0-dev-093556a0bae433bd3994753b17198805bf4e91d8-pr-26/shellcheck-result.xml

Tag Passed
amd64-f88d46ed-pkg-089d8eb0-dev-093556a0bae433bd3994753b17198805bf4e91d8-pr-26
arm64v8-f88d46ed-pkg-089d8eb0-dev-093556a0bae433bd3994753b17198805bf4e91d8-pr-26

@thespad thespad merged commit bff2f96 into linuxserver:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Can't see other devices within subnet using provided docker-compose yml snippet
3 participants