Fix list segfault #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entries were memset() to zero to erase them on eventUpdate, unintentionally erasing the list member and corrupting the list they are contained in. This resets the list member to its original value after all members have been zeroed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries were memset() to zero to erase them on eventUpdate,
unintentionally erasing the list member and corrupting the list they
are contained in. This resets the list member to its original value
after all members have been zeroed.
This fixes a null dereference in
event_delete, that occurs when the entry after or before the corrupted entry is deleted. There,list_delwould dereference the next pointer of the previous entry (and vice-versa), dereferencing a zeroed value.This issue caused pidvbip to crash at least once per day for me, I have not experienced any such crash with this patch applied in some limited testing.