fix: percent sign was not properly encoded TDE-1767#1305
Draft
paulfouquet wants to merge 6 commits intomasterfrom
Draft
fix: percent sign was not properly encoded TDE-1767#1305paulfouquet wants to merge 6 commits intomasterfrom
paulfouquet wants to merge 6 commits intomasterfrom
Conversation
paulfouquet
added
container
paulfouquet
added
container
paulfouquet
added
container
Contributor
Author
|
We don't want to push this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
create-manifestis listing files containing%in their file name, for examples3://hydro-data-bucket-418528898914/Authoritative_Surveys/HS72-Processed/3_Processed/1_GSF_PROJECTS/HS72_Block A_GSF_Project/SD/HS72_A_95%_C.I_4m_40-110m.sd, the system fails with aURI malformederror. It expects the%to be followed by a double hex to code a special char.The same issue happens with the
copycommand when the decoded URI is passed to the https://github.com/blacha/chunkd library.Modifications
When the file name in the path returned by the file list component contains a
%that is not a code, the percent sign should be encoded as%25so when decoding the path it does transform it back to%as it should be.Re-encode
%to%25in a place where the URI is stringified to be passed to a FSA to avoid the issue happening.Verification
Unit tests, Argo Workflows