Skip to content

Commit

Permalink
fix(server): Bundle the the bin file before publish NPM. BM-1083 (#3375)
Browse files Browse the repository at this point in the history
### Motivation

The
[@basemaps/server](https://www.npmjs.com/package/@basemaps/server?activeTab=code)
npm package is missing the bin file for excusing the command. We need to
bundle it first before publish the package.

### Modifications

Add a bundle command before NPM publish

### Verification

Locally tested. 

- delete the `server/bin/basemaps-server.cjs`
- run `npx lerna run bundle --stream` -> Got a new
`server/bin/basemaps-server.cjs` generated.
- run `npm pack --dry-run` -> Got bin file included.

![image](https://github.com/user-attachments/assets/812f27cc-0f0c-47d3-b2fb-c37066f569ea)

---------

Co-authored-by: Tawera Manaena <TManaena@linz.govt.nz>
  • Loading branch information
Wentao-Kuang and tawera-manaena authored Nov 21, 2024
1 parent bc334d4 commit 5ce567f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
steps:
- uses: linz/action-typescript@v3

- name: Bundle
run: |
npx lerna run bundle --stream
# TODO: running a giant copy command to import CSS and SVG files into the docs file in not super ideal
- name: Build docs
run: |
Expand Down

0 comments on commit 5ce567f

Please sign in to comment.