-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cogify): add background color support for overriding transparent pixels BM-1146 #3379
Merged
Wentao-Kuang
merged 17 commits into
master
from
feat/cogify-add-background-color-support
Jan 6, 2025
Merged
feat(cogify): add background color support for overriding transparent pixels BM-1146 #3379
Wentao-Kuang
merged 17 commits into
master
from
feat/cogify-add-background-color-support
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawera-manaena
changed the title
feat(cogify): force a background color for transparent pixels
feat(cogify): force a background color for transparent pixels BM-1146
Dec 12, 2024
tawera-manaena
changed the title
feat(cogify): force a background color for transparent pixels BM-1146
feat(cogify): add background color support for overriding transparent pixels BM-1146
Dec 12, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 16, 2024
blacha
reviewed
Dec 20, 2024
blacha
reviewed
Dec 20, 2024
blacha
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a Basemaps user, when I view the NZTopo Raster Maps from afar (low zoom level), I can see black edge artifacts around the perimeter of the imagery.
0-6
inclusive. Hard to notice when zoom level is>= 6.5
0-4
inclusive. Hard to notice when zoom level is>= 4.5
You may need to open each image/link in a new tab to see the black lines more clearly.
Problem
We suspect the issue resides in the way the basemaps/tiler composes a small tile. The resizing down of many pixels into one, causes artifacts to appear where opaque pixels meet transparent pixels.
Solution
There is already a 'workaround' fix that treats the symptoms of the black edge artifacts. This work, however, seeks to treat the source of the issue by providing a mechanism to replace all transparent pixels with opaque pixels. The effect being to erase such areas where opaque pixels meet transparent pixels.
Modifications
basemaps/cogify
We have added a
background
parameter to thecover
command.When the user provides the parameter, the
create
function will perform two additionalgdal
steps aftergdalwarp
and beforegdal_translate
, to ensure that any and all transparent pixels that would otherwise appear in the resulting tile, are replaced with the provided background colour.gdal_create
- To create a background image where all pixels are set to the provided background colour.gdalbuildvrt
- To layer the background image behind the source GeoTIFF files after reprojection.Verification