fix(tiler-sharp): when resampling uint round numbers rather than truncate BM-1178 #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawera-manaena
approved these changes
Jan 22, 2025
blacha
changed the title
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
# [7.14.0](v7.13.0...v7.14.0) (2025-01-26) ### Bug Fixes * **infra:** correct dist path location ([#3390](#3390)) ([46f8fb8](46f8fb8)) * revert "build: maplibre v5.0.0 ([#3387](#3387))" ([#3394](#3394)) ([d441be2](d441be2)) * **tiler-sharp:** when resampling uint round numbers rather than truncate ([#3392](#3392)) ([d02e56f](d02e56f)) ### Features * **cogify:** add background color support for overriding transparent pixels BM-1146 ([#3379](#3379)) ([b8bedc3](b8bedc3)) * improved cloudwatch analytics rollup BM-1092 ([#3381](#3381)) ([de2f295](de2f295)) * **tiler-sharp:** support uint32 and uint8 source datasets for color-ramp ([#3391](#3391)) ([f316042](f316042))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When resampling
uintit can end up resampling slightly high or low eg resampling1can result in1.00..01or0.99999..When setting a number on a Uint8Array floating point numbers are truncated, so
0.9999will be rounded down to0rather than up to1.Modifications
When resampling
uintround numbers before assigning them.Verification
Added unit test to validate rounding