Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardization with PHPStan and PHP_CodeSniffer is added #119

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Standardization with PHPStan and PHP_CodeSniffer is added #119

merged 3 commits into from
Feb 8, 2025

Conversation

Sleon4
Copy link
Member

@Sleon4 Sleon4 commented Feb 8, 2025

Added

  • Standardization with PHPStan and PHP_CodeSniffer is added.
  • Added coverage tests.

Changed

  • Updated Github Actions settings.

@Sleon4 Sleon4 added tests Tests have been added continuous integration Contains changes to continuous integration standardization The changes made standardize the developed code labels Feb 8, 2025
@Sleon4 Sleon4 added this to the Support and maintenance milestone Feb 8, 2025
@Sleon4 Sleon4 requested a review from GabrielPalac February 8, 2025 20:00
@Sleon4 Sleon4 self-assigned this Feb 8, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
src/LionBundle/Commands/Lion/DB/CrudCommand.php 100.00% <ø> (+0.51%) 4.00 <0.00> (-19.00) ⬆️

... and 1 file with indirect coverage changes

@Sleon4 Sleon4 force-pushed the support branch 2 times, most recently from 6276a5f to c03f126 Compare February 8, 2025 20:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GabrielPalac GabrielPalac merged commit 2133946 into main Feb 8, 2025
5 checks passed
@GabrielPalac GabrielPalac deleted the support branch February 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielPalac GabrielPalac GabrielPalac approved these changes

Assignees

@Sleon4 Sleon4

Labels
continuous integration Contains changes to continuous integration standardization The changes made standardize the developed code tests Tests have been added
Projects
None yet
Milestone
Support and maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@Sleon4 @GabrielPalac