Skip to content

Conversation

@lionralfs
Copy link
Owner

fixes #426

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a type inconsistency in marketplace order IDs by changing them from number to string to match the actual Discogs API format (e.g., '1-1'). This addresses issue #426 and ensures type safety when working with marketplace orders.

  • Changed GetOrderResponse.id type from number to string
  • Updated function parameter types for order-related methods (getOrder, editOrder, getOrderMessages, addOrderMessage) from number to string
  • Updated all unit and integration tests to use string order IDs (e.g., '1-1' instead of 1)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lib/marketplace.ts Updated type definitions and function signatures to accept string order IDs; updated JSDoc examples to use string format
test/unit/marketplace.test.ts Updated unit test to use string order ID '1-1' instead of numeric 1
test/integration/marketplace.test.ts Updated all integration tests for order-related operations to use string order IDs
CHANGELOG.md Added entry documenting the fix for version 4.1.4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lionralfs lionralfs merged commit e6215bc into main Nov 30, 2025
4 checks passed
@lionralfs lionralfs deleted the fix/426 branch November 30, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order ID should be a string instead of a number

1 participant