Add support for symbolic links #37
Conversation
- Add support for symbolic links in S3 - Check for symlinks during `read` and directory traversal - Add `S3Path.is_symlink`, `S3Path.symlink_to`, `_S3Accessor.symlink`, and `_S3Accessor.is_symlink` - Refactor `ObjectSummary` instantiation to a separate method to allow for a new `follow_symlinks` argument to be passed, which, if True, results in the final non-symlink `ObjectSummary` instance being returned - Fixes liormizr#35 Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
techalchemy
force-pushed
the
feature/symlink
branch
3 times, most recently
from
1d0bad9 to
ea17a63
Compare
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
techalchemy
force-pushed
the
feature/symlink
branch
from
ea17a63 to
f66ad6c
Compare
There was a problem hiding this comment.
Hi @techalchemy looks like an interesting feature and a great start.
I have few questions before will start a proper code review.
first think - you didn't modify the lstat method this method looks like a great please to put the indication that this path is a symbolic link...
Also are you handling that if the path is symbolic link stat method will return the "target" info?
Also do we want to keep the old behavior (raise no support exception) if the bucket is not set as a website bucket type?
What do you think?
| @@ -519,3 +520,25 @@ def test_unlink(s3_mock): | |||
| S3Path("/test-bucket/fake_folder").unlink() | |||
| with pytest.raises(IsADirectoryError): | |||
| S3Path("/fake-bucket/").unlink() | |||
|
|
|||
There was a problem hiding this comment.
How are you testing the change that you did in the _S3Accessor?
I think that we need to add a test that check glob/rglob/iterdir with symlink and not "normal" keys right?
readand directory traversalS3Path.is_symlink,S3Path.symlink_to,_S3Accessor.symlink,and
_S3Accessor.is_symlinkObjectSummaryinstantiation to a separate method to allowfor a new
follow_symlinksargument to be passed, which, if True,results in the final non-symlink
ObjectSummaryinstance beingreturned
Signed-off-by: Dan Ryan dan.ryan@canonical.com