Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix French flags color to use official ones #1163

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

mathix420
Copy link
Contributor

Updated french flags colors to follow official guidelines for every gouvernement-linked websites.

https://www.gouvernement.fr/charte/charte-graphique-les-fondamentaux/les-couleurs (sorry did not find any translation for this website)

image

@lipis
Copy link
Owner

lipis commented Oct 26, 2023

Thank you!

@lipis lipis merged commit 90c6410 into lipis:main Oct 26, 2023
2 checks passed
@FlorianLeChat
Copy link

This is incorrect. Since 2021, the French President has returned to the colors of the pre-1976 flag, dropping the European flag's blue color in favor of the one used during the Revolution. The government's design system is probably not yet up to date, but the coat of arms has definitely been changed, for example on Wikipedia, which uses the correct colors:

@mathix420
Copy link
Contributor Author

Yes the physical flag has changed recently, the government's graphical system too but it's still lighter than the physical flag.

Cette charte sera remplacée en 2020, la nouvelle utilisant des couleurs plus proches de celles du drapeau original (tout en restant toutefois plus vives).
https://fr.m.wikipedia.org/wiki/Drapeau_de_la_France#Couleurs

Sorry for the french again, but most up to date articles are in french.

@FlorianLeChat
Copy link

Well, I guess the current modification is good in this case, let's keep an eye on it if the system design decides to follow exactly the physical flag.

@mathix420
Copy link
Contributor Author

Sure, following government design system is the best idea in my opinion too!

@lipis
Copy link
Owner

lipis commented Nov 2, 2023

So what should I do?

@FlorianLeChat
Copy link

Nothing at all, this change is fine 👌

@lipis
Copy link
Owner

lipis commented Nov 2, 2023

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants