redesign phase info component #5385
Conversation
hom3mad3
changed the title
hom3mad3
changed the title
hom3mad3
changed the title
hom3mad3
changed the title
hom3mad3
force-pushed
the
mr-2024-01-phase-info-component
branch
from
b3f37b6 to
a01b612
Compare
| @@ -1,61 +1,41 @@ | |||
| // import { Swiper, Pagination, A11y } from 'swiper' | |||
| // import django from 'django' | |||
| import Swiper from 'swiper/bundle' | |||
There was a problem hiding this comment.
works for me™ and follows swiper documentation. not sure what else to do
failed tests:
The tests are failing in our testing environment, and I don't have the means to debug the issue as I'm unable to replicate the problem locally. |
|
@hom3mad3 hmm that's probably because we no longer install swiper as the BO styleguide to avoid a doubling up, but it is weird it's not failing locally, I'll have a look, maybe we need to import it differently or something |
|
@hom3mad3 checking this i'm still not sure why the additional swiper.js is required? the swiper should be initialized by the BO js, is it just the style overwrites? maybe we can talk tomorrow? |
this was the only way i could find to be able to style the swiper pagination and make it accessible, otherwise i cannot access the Swiper object which as been instantiated by the BO component and add customizations. i removed the modul-buhne element which initializes the swiper and was causing the issue. |
philli-m
force-pushed
the
mr-2024-01-phase-info-component
branch
from
e9a7d06 to
f19c276
Compare
| @@ -50,7 +50,7 @@ | |||
| @import "../berlin_css/berlin_marketing"; | |||
|
|
|||
| // extra scss / overwrites | |||
| @import "../extra_css/swiper.scss"; | |||
| @import "../extra_css/swiper"; | |||
There was a problem hiding this comment.
removed as didn't pass linter, not sure why there wasn't an error when commiting, maybe we need to check out commit linting?
| @@ -26,7 +34,7 @@ const initSwiper = () => { | |||
| } | |||
|
|
|||
| createSwiper(config) | |||
| }; | |||
| } | |||
| import 'swiper/css' | ||
| import 'swiper/css/navigation' | ||
| import 'swiper/css/pagination' | ||
| /* eslint-enable import/no-unresolved */ |
There was a problem hiding this comment.
This is apparently a known issue, have added link, also just did a little update to only import the used modules as the bundle is a bit big also we don't seem to use any of the A11y module options so didn't add it, but not sure if i'm reading it all right
philli-m
force-pushed
the
mr-2024-01-phase-info-component
branch
from
f19c276 to
67c284c
Compare
fair play, might make the liberary integration a bit of a pain but I am hoping that will not be our job :p Happy to merge when tests pass, just left some comments as change the import a bit, let me know if that's ok?! |
|
@philli-m thanks for taking the time to figure this out. as expected, the code doesn't work for me locally anymore, probably due to the import changes :( this really is a problem, that we get to work with such different local environments and they don't necessarily reflect the server settings. all in all i am extremely happy and relieved to get this merged @m4ra @goapunk just as a heads up, as this is likely to keep happening |
Redesign Phase Info Component
Test Page
projekte/module/module-title(e.g., Participatory Budgeting Phase 3)Changes
Previews
Tasks