templates/project_detail: add title to tab content fixes #5376 #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hom3mad3
reviewed
Jan 22, 2024
| @@ -125,6 +125,7 @@ <h1 class="title">{{ project.name }}</h1> | |||
| aria-expanded="false" | |||
| aria-hidden="true" | |||
| aria-labelledby="tab-project-{{ project.pk }}-information"> | |||
| <h2>{% translate 'Information' %}</h2> | |||
There was a problem hiding this comment.
now i'm confused whether to use double or singles quotes? the other PR uses two.
There was a problem hiding this comment.
@hom3mad3 me to, both prs passed the linting when I cherry picked the commits?! when I make lint-html-fix it keeps the single quotes so I assume they are correct, will change the other PR
hom3mad3
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Briefly explain what you did and provide context for a clearer understanding.
Tasks
fix can be seen on project detail http://localhost:8003/projekte/liqd-project/
added title to tab pages fixes #5376
expected outcome:
