Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix email signature #5416

Closed
wants to merge 1 commit into from
Closed

fix email signature #5416

wants to merge 1 commit into from

Conversation

xi
Copy link
Contributor

@xi xi commented Jan 25, 2024

@goapunk goapunk added the Status: Blocked blocked due to dependencies or updates label Jan 25, 2024
@goapunk
Copy link
Contributor

goapunk commented Jan 29, 2024

hi @xi,
thanks for the fix and the link to the docs! We are currently still in the process of clarifying some issues around accepting PRs from external contributors and I would therefore refrain from merging your PR until we resolved them :/ We discussed the change and generally agree that we would like to fix the non-standard signature dashes. If you don't mind I would open a new PR and close this one so it is included in the upcoming release

@xi
Copy link
Contributor Author

xi commented Jan 29, 2024

It feels a bit strange to be an "external contributor" when most of the commits in this repo were created by me 😄. But true, it's been a few years. For a small change like this I see no harm in creating a new PR if that makes things easier for you.

@goapunk
Copy link
Contributor

goapunk commented Jan 29, 2024

It feels a bit strange to be an "external contributor" when most of the commits in this repo were created by me 😄. But true, it's been a few years. For a small change like this I see no harm in creating a new PR if that makes things easier for you.

fair point ;-) It's sadly about legal things though, not experience :) Will make a new PR tomorrow

@goapunk goapunk closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked blocked due to dependencies or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants