feat: parses Liquibase local build DEV version #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
force-pushed
the
fix-dev-version
branch
from
a4dd71d to
fbbf7c8
Compare
filipelautert
changed the title
…re that lpm believes this is the latest version ever.
filipelautert
force-pushed
the
fix-dev-version
branch
from
bcc1d3a to
1a3a3c8
Compare
|
|
@filipelautert : is this still a valid PR? If yes, can we merge it? |
|
@sayaliM0412 still a valid PR. IMHO it can be merged. |
|
I'm not a fan of adding this logic to lpm. I'm not sure we should support this use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: when building liquibase locally version is set to
DEVinstead of the expectedMAJOR.MINOR.PATCHpattern -> https://github.com/liquibase/liquibase/blob/1b8546371a2a29aee5d25286bbf111ed3b544d0a/liquibase-standard/src/main/resources/liquibase.build.properties#L7This PR ensures that lpm believes this is the latest version ever.