Merge pull request #185 from liquidz/dev

fix: Add exception handling for antq.changelog
liquidz · Sep 19, 2022 · 464e895 · 464e895
2 parents 5bdbd2d + 4302a4b
commit 464e895
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -1,6 +1,13 @@
 All notable changes to this project will be documented in this file. This change log follows the conventions of http://keepachangelog.com/[keepachangelog.com].
 
 == Unreleased (dev)
+// {{{
+=== Changed
+* Bumped kaocha to 1.70.1086.
+
+=== Fixed
+* https://github.com/liquidz/antq/issues/184[#184]: Fixed not to throw exception for checking changelogs.
+// }}}
 
 == 2.1.920 (2022-09-18)
 // {{{

diff --git a/deps.edn b/deps.edn
@@ -23,7 +23,7 @@
   :dev
   {:extra-paths ["test"
                  "test/resources"]
-   :extra-deps {lambdaisland/kaocha {:mvn/version "1.69.1069"}
+   :extra-deps {lambdaisland/kaocha {:mvn/version "1.70.1086"}
                 lambdaisland/deep-diff2 {:mvn/version "2.4.138"}}
    :jvm-opts ["-Dclojure.core.async.go-checking=true"]}
 

diff --git a/src/antq/changelog.clj b/src/antq/changelog.clj
@@ -16,8 +16,12 @@
 
 (defn- silent-procure
   [url lib rev]
-  (binding [*err* (java.io.StringWriter.)]
-    (gitlibs/procure url lib rev)))
+  (try
+    (binding [*err* (java.io.StringWriter.)]
+      (gitlibs/procure url lib rev))
+    (catch Exception _
+      ;; Ignore exception for fallback to diff url
+      nil)))
 
 (defn- get-root-file-names
   [url lib rev]