Feat simplify onAfterAllocateLQTY
hook
#12
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
assert
foronAfterAllocateLQTY
to ensure the code works as the specRewrite the code to be easier to read
Simplify the code
Implement tests for it
E2E / Fuzz for reverts
Invariant Tests for accounting and reverts
Fix Tests
These tests are currently broken:
I believe they were implemented incorrectly as they were allowing one caller to both vote and veto, but I wanted to make sure.
CC: @jltqy @ColinPlatt