Add extra oracle tests #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
reviewed
Jan 21, 2025
contracts/test/OracleMainnet.t.sol
Outdated
| // Etch the mock code to the RETH token address | ||
| vm.etch(address(rethToken), _mockTokenCode); | ||
| // // Wrap so we can use the mock's functions | ||
| // GasGuzzlerToken mockReth = GasGuzzlerToken(address(rethToken)); |
contracts/test/OracleMainnet.t.sol
Outdated
| // After etching the gas guzzler to the LST, confirm the same call with 500k gas now reverts due to OOG | ||
| vm.expectRevert(MainnetPriceFeedBase.InsufficientGasForExternalCall.selector); | ||
| // just catch return val to suppress warning | ||
| (success,) = address(wstethPriceFeed).call{gas: 10000}(abi.encodeWithSignature("fetchPrice()")); |
There was a problem hiding this comment.
The comment says “the same call with 500k”, but we are sending only 10k?
contracts/test/OracleMainnet.t.sol
Outdated
| // After etching the gas guzzler to the LST, confirm the same call with 500k gas now reverts due to OOG | ||
| vm.expectRevert(MainnetPriceFeedBase.InsufficientGasForExternalCall.selector); | ||
| // just catch return val to suppress warning | ||
| (success,) = address(rethPriceFeed).call{gas: 10000}(abi.encodeWithSignature("fetchPrice()")); |
contracts/test/OracleMainnet.t.sol
Outdated
|
|
||
| function testRevertLowGasRETHToken() public { | ||
| // Confirm call to the real external contracts succeeds with sufficient gas i.e. 500k | ||
| (bool success,) = address(wstethPriceFeed).call{gas: 500000}(abi.encodeWithSignature("fetchPrice()")); |
There was a problem hiding this comment.
Shouldn’t this be rethPrice?
| } | ||
|
|
||
| // WSTETH exchange rate getter | ||
| function stEthPerToken() external view returns (uint256) { |
There was a problem hiding this comment.
Don’t we need one for RETH?
bingen
approved these changes
Jan 22, 2025
| (bool success,) = address(wstethPriceFeed).call{gas: 10000}(abi.encodeWithSignature("fetchPrice()")); | ||
| assertFalse(success); | ||
| (bool revertAsExpected,) = address(wstethPriceFeed).call{gas: 500000}(abi.encodeWithSignature("fetchPrice()")); | ||
| assertTrue(revertAsExpected); |
There was a problem hiding this comment.
Interesting, so when the failure is catched by vm.expecRevert then bool return value is true?
There was a problem hiding this comment.
Yes, strange design choice in Foundry IMO. See the "Gotcha: low level calls" section here:
https://book.getfoundry.sh/cheatcodes/expect-revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.