fix(typeformclient): echo api errors back to users (#6)

lirantal · Jan 28, 2019 · 48a439f · 48a439f
1 parent 32287fd
commit 48a439f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/__tests__/Form/form.test.js b/__tests__/Form/form.test.js
@@ -90,14 +90,15 @@ describe('Form', () => {
         forms: {
           get: jest.fn(() => {
             return {
-              code: 'FORM_NOT_FOUND'
+              code: 'FORM_NOT_FOUND',
+              description: 'form not found'
             }
           })
         }
       }
 
       await expect(form._fetchForm(mockFormId)).rejects.toThrowError(
-        'Form not found, check the provided credentials'
+        'Typeform API returned an error: form not found'
       )
     })
   })

diff --git a/src/Form/Form.js b/src/Form/Form.js
@@ -14,8 +14,8 @@ module.exports = class Form {
     const form = {}
     const formResult = await this.client.forms.get({uid: formId})
 
-    if (formResult.code && formResult.code === 'FORM_NOT_FOUND') {
-      throw new Error('Form not found, check the provided credentials')
+    if (formResult.code) {
+      throw new Error(`Typeform API returned an error: ${formResult.description}`)
     }
 
     form.id = formResult.id