-
Notifications
You must be signed in to change notification settings - Fork 1
Add preflight validation checks for ROS workspace and git synchronization #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
57
commits into
devel
Choose a base branch
from
copilot/fix-76e64063-6547-499b-8ff1-3e6e64508919
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Charbel Toumieh <charbel.toumieh@epfl.ch>
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
…b8-6658fe26c54c Fix ROS nodes not shutting down cleanly with systemctl stop
…ration Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
…4e3-6701955ad2ab Replace ineffective WiFi power saving systemd service with NetworkManager configuration
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
…155-17b07ba6c518 Add domain_bridge node to host launch file
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
…8c2-7836169d8f61 Add bash aliases for ROS packages systemctl management
Co-authored-by: nielmistry <10933146+nielmistry@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] early in the preflight for the drones, can you add a task in the ansible to:
1. check if ~/ros2_swarmnxt_ws/install/ exists
2. if the git version of ~/repos/swarm-nxt matches the local repo
if either of these checks fail i want to fail the play for t...
Add preflight validation checks for ROS workspace and git synchronization
Aug 25, 2025
Copilot finished work on behalf of
nielmistry
August 25, 2025 14:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds essential preflight validation checks to the drone setup process to prevent deployment issues and ensure consistency across the swarm.
Problem
During drone preflight operations, there was no validation to ensure that:
This could lead to runtime failures or inconsistent behavior across the swarm when drones had missing dependencies or outdated code.
Solution
Added a new "Pre-flight Validation Checks" block to
ansible/drones_preflight.ymlthat performs two critical validations for each drone:1. ROS2 Workspace Validation
Verifies that
~/ros2_swarmnxt_ws/install/exists, indicating the workspace has been properly built.2. Git Version Synchronization Check
Compares the git commit hash between the local deployment repository and each drone's
~/repos/swarm-nxtto ensure code synchronization.Behavior
Example failure messages:
"ROS2 workspace install directory /home/lis/ros2_swarmnxt_ws/install does not exist on drone-01. Please ensure the workspace is properly built.""Git version mismatch on drone-01. Local: abc123..., Drone: def456.... Please ensure both repositories are synchronized."Impact
This enhancement improves the reliability of drone operations by catching configuration issues early in the deployment process, reducing the likelihood of mid-flight failures due to missing dependencies or code mismatches.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.