Skip to content

Commit

Permalink
Fix:JCenter に依存している関係でビルドが通らない
Browse files Browse the repository at this point in the history
JCenter に依存している関係でビルドが通らなかった。
JCenter への依存をやめるためライブラリ・Gradle・Gradle Pluginのバージョンを更新。
  • Loading branch information
takara727 committed Nov 8, 2024
1 parent 2c7e4a9 commit fc9821a
Show file tree
Hide file tree
Showing 10 changed files with 44 additions and 32 deletions.
16 changes: 8 additions & 8 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext.kotlin_version = '1.4.21'
ext.android_min_sdk_version = 21
ext.android_target_sdk_version = 28
ext.android_compile_sdk_version = 29
ext.android_build_tools_version = '29.0.3'
ext.kotlin_version = '1.9.23'
ext.kotlin_coroutines_version = '1.8.0'
ext.android_min_sdk_version = 28
ext.android_target_sdk_version = 34
ext.android_compile_sdk_version = 34

repositories {
jcenter()
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:4.1.1'
classpath 'com.android.tools.build:gradle:8.7.2'
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
Expand All @@ -20,7 +20,7 @@ buildscript {
allprojects {
repositories {
mavenLocal()
jcenter()
google()
mavenCentral()
}
}
15 changes: 12 additions & 3 deletions example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'

android {
compileSdkVersion android_compile_sdk_version
buildToolsVersion android_build_tools_version
namespace "com.lisb.android.mediashrink.example"
compileSdk android_compile_sdk_version

defaultConfig {
minSdkVersion android_min_sdk_version
Expand All @@ -12,11 +12,20 @@ android {
versionCode 1
versionName "1.0"
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

kotlinOptions {
jvmTarget = "1.8"
}
}

dependencies {
implementation project(':library')
implementation 'com.google.android.material:material:1.2.1'
implementation 'com.google.android.material:material:1.12.0'
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
}

6 changes: 3 additions & 3 deletions example/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.lisb.android.mediashrink.example">
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

Expand All @@ -14,7 +13,8 @@

<activity
android:name="com.lisb.android.mediashrink.example.ExampleActivity"
android:label="@string/app_name" >
android:label="@string/app_name"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
18 changes: 11 additions & 7 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,30 @@ apply plugin: 'kotlin-android'
apply plugin: 'maven-publish'

android {
compileSdkVersion android_compile_sdk_version
buildToolsVersion android_build_tools_version
namespace "com.lisb.android.mediashrink"
compileSdk android_compile_sdk_version

defaultConfig {
minSdkVersion android_min_sdk_version
targetSdkVersion android_target_sdk_version
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_7
targetCompatibility JavaVersion.VERSION_1_7
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

kotlinOptions {
jvmTarget = "1.8"
}
}

dependencies {
api fileTree(dir: 'libs', include: '*.jar')
api 'com.jakewharton.timber:timber:4.7.1'
api 'com.jakewharton.timber:timber:5.0.1'
api "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9'
api 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9'
api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.0'
api 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.0'
}

task androidSourcesJar(type: Jar) {
Expand Down
5 changes: 1 addition & 4 deletions library/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.lisb.android.mediashrink"
android:versionCode="1"
android:versionName="1.0" >
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
</application>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,13 @@ internal class MediaShrink(private val context: Context) {
onProgressListener?.onProgress(progress * 100 / maxProgress)
}

@Throws(TooMovieLongException::class)
@Throws(TooMovieLongException::class, IOException::class)
private fun checkLength(metadataRetriever: MediaMetadataRetriever) {
if (durationLimit <= 0) return
val durationSec = (metadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION)).toLong() / 1000
val duration =
metadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION)
?: throw IOException("Failed to read duration.")
val durationSec = duration.toLong() / 1000
if (durationSec > durationLimit) {
Timber.tag(TAG).e("Movie duration(%d sec) is longer than duration limit(%d sec).",
durationSec, durationLimit)
Expand All @@ -205,9 +208,6 @@ internal class MediaShrink(private val context: Context) {
private const val PROGRESS_ADD_TRACK = 10
private const val PROGRESS_WRITE_CONTENT = 40
fun isSupportedDevice(context: Context): Boolean {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN_MR2) {
return false
}
return OpenglUtils.supportsOpenglEs2(context)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ class VideoShrink(private val extractor: MediaExtractor,
metadataRetriever: MediaMetadataRetriever,
private val muxer: MediaMuxer,
private val errorCallback: UnrecoverableErrorCallback) {
private val rotation = metadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_ROTATION).toInt()
private val rotation =
metadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_ROTATION)
?.toInt() ?: 0
var bitRate = 0

/**
Expand Down

0 comments on commit fc9821a

Please sign in to comment.