needrestart: fix container detection on rootless podman#346
Open
89luca89 wants to merge 1 commit intoliske:masterfrom
Open
needrestart: fix container detection on rootless podman#34689luca89 wants to merge 1 commit intoliske:masterfrom
89luca89 wants to merge 1 commit intoliske:masterfrom
Conversation
Right now /proc/1/environ might not accessible in case of rootless podman containers, in case we're not using a pid namespace, for example: ``` default_distrobox:needrestart$ sudo cat /proc/1/environ cat: /proc/1/environ: Permission denied default_distrobox:needrestart$ sudo /usr/sbin/needrestart readline() on closed filehandle HENV at /usr/sbin/needrestart line 79. Use of uninitialized value in unpack at /usr/sbin/needrestart line 79. readline() on closed filehandle HENV at /usr/sbin/needrestart line 79. Use of uninitialized value in unpack at /usr/sbin/needrestart line 79. ``` This PR will instead use the current process' ppid to detect environ, so we're sure we have read access to it. This is not a breaking change, it still works on rootful podman containers, and in namespaced pids. Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now /proc/1/environ might not be accessible in case of rootless podman containers, in case we're not using a pid namespace, for example:
This PR will instead use the current process' ppid to detect environ, so we're sure we have read access to it.
This is not a breaking change, it still works on rootful podman containers, and in namespaced pids.