Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making some DI responses synchronous #1883

Closed
5 tasks done
Kailai-Wang opened this issue Jul 12, 2023 · 1 comment · Fixed by #1920
Closed
5 tasks done

Making some DI responses synchronous #1883

Kailai-Wang opened this issue Jul 12, 2023 · 1 comment · Fixed by #1920
Assignees
@Kailai-Wang
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days

Comments

@Kailai-Wang
Copy link
Collaborator

Kailai-Wang commented Jul 12, 2023 •
edited
Loading

Context

To further reduce the waiting time, we'd like to make some DI responses synchronous, that is, do not post the responses as parachain event, but return to the caller as rpc results.

For the following calls:

  • set_user_shielding_key
  • activate_identity
  • deactivate_identity
  • set_identity_networks
  • link_identity

For VC issuance it needs to change parachain storage so we'll keep it unchanged.
It's medium prio now but still, it would be great if we can finish it soon.

✔️ Please set appropriate labels and assignees if applicable.
@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days D1-feature A new feature, a piece of functionality that needs to be developed labels Jul 12, 2023
@Kailai-Wang Kailai-Wang self-assigned this Jul 18, 2023
This was referenced Jul 21, 2023
Merged
Open
@Kailai-Wang Kailai-Wang linked a pull request Jul 23, 2023 that will close this issue
Make some DI responses synchronous #1920
Merged
2 tasks
@Kailai-Wang
Copy link
Collaborator Author

PR submitted.

Will have follow-up issues for TODOs.

This was referenced Jul 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kailai-Wang Kailai-Wang

Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make some DI responses synchronous litentry/litentry-parachain
1 participant
@Kailai-Wang