Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Clickhouse #2840

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

humberaquino
Copy link
Contributor

@humberaquino humberaquino commented Oct 25, 2024

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@humberaquino humberaquino marked this pull request as draft October 25, 2024 20:31
@josevalim
Copy link
Contributor

Thank you, this is great but we should wait with merging it until there is a new kino_db version!

@humberaquino
Copy link
Contributor Author

Thank you, this is great but we should wait with merging it until there is a new kino_db version!

Awesome! Should I live this PR as draft until then or mark it "Ready for review". Both work for me

@jonatanklosko jonatanklosko marked this pull request as ready for review November 28, 2024 12:41
Copy link

github-actions bot commented Nov 28, 2024

Uffizzi Preview deployment-58654 was deleted.

@josevalim
Copy link
Contributor

@jonatanklosko this is good to go to me. We can either ship this now with a new kino_db or wait until we are done with req_bigquery and req_athena refactors.

@jonatanklosko
Copy link
Member

I published kino_db, will do another one after the refactor.

@jonatanklosko jonatanklosko merged commit 31ba212 into livebook-dev:main Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants