Added win build in release (experimental) #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royra
approved these changes
Oct 16, 2023
| @@ -34,7 +34,7 @@ module.exports = { | |||
| plugins: ['import', 'jest', '@typescript-eslint'], | |||
| rules: { | |||
| 'no-void': ['warn', { allowAsStatement: true }], | |||
| 'linebreak-style': ['warn', isWindows ? 'windows' : 'unix'], | |||
| 'linebreak-style': ['warn', 'unix'], | |||
There was a problem hiding this comment.
why is this needed? I expected it to work with git's autocrlf setting - locally checked out files should have the native OS's line endings, and they will be converted to unix when pushed.
There was a problem hiding this comment.
When I run locally, it created a lot of noise and added files to the commit itself.
| @@ -69,6 +69,8 @@ const volumeSkipList = [ | |||
| /^\/$/, | |||
| ] | |||
|
|
|||
| const toPosix = (x:string) => x.split(path.sep).join(path.posix.sep) | |||
There was a problem hiding this comment.
what is the difference between this and
x.replaceAll(path.sep, path.posix.sep)There was a problem hiding this comment.
I assume there's no difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Is this a bugfix/feature/doc-improvement?]
This is a
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
If this is a bug fix or feature: