Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not set fnc_ctx to None for anthropic at max depth #1441

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: Do not set fnc_ctx to None for anthropic at max depth #1441

wants to merge 4 commits into from
+50 −14

Conversation

jayeshp19
Copy link
Collaborator

  • Added an additional field in LLM capabilities class to check if model providers support function call history within chat context without needing function definitions.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b4084a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayeshp19 jayeshp19 requested a review from a team February 3, 2025 08:51
theomonnom
theomonnom reviewed Feb 3, 2025
View reviewed changes
livekit-agents/livekit/agents/llm/llm.py
@@ -50,6 +50,7 @@ class Choice:
@dataclass
class LLMCapabilities:
supports_choices_on_int: bool = True
supports_function_history_without_fnc_ctx: bool = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a better name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about requires_explicit_tool_context? feel free to suggest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayeshp19 @theomonnom