Delete segments after upload if upload is enabled #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frostbyte73
reviewed
Jun 30, 2023
| type baseUploader struct { | ||
| } | ||
|
|
||
| func (u *baseUploader) cleanupFile(localFilepath string) error { |
There was a problem hiding this comment.
func (u *Uploader) cleanupFile(localFilepath string) error {
There was a problem hiding this comment.
Wouldn't the cause the file to be deleted as well in cases where there is no cloud upload (which I believe means that the noopUploader is selected)?
There was a problem hiding this comment.
oh, true. In that case, better to kill *Uploader and change the uploader interface to be public.
Then the backup logic can move into baseUploader
frostbyte73
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this safe to do?