Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline/Bin subclassing #468

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Pipeline/Bin subclassing #468

merged 10 commits into from
Aug 23, 2023

Conversation

frostbyte73
Copy link
Member

@frostbyte73 frostbyte73 commented Aug 19, 2023

Moves all linking, state change, and EOS code into the pipeline/bin classes

@frostbyte73 frostbyte73 marked this pull request as draft August 19, 2023 09:08
@frostbyte73 frostbyte73 marked this pull request as ready for review August 22, 2023 22:29
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! just a few comments.

pkg/gstreamer/bin.go Show resolved Hide resolved
pkg/gstreamer/bin.go Outdated Show resolved Hide resolved
pkg/gstreamer/pipeline.go Show resolved Hide resolved
pkg/gstreamer/bin.go Show resolved Hide resolved
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@frostbyte73 frostbyte73 merged commit 45d36b1 into main Aug 23, 2023
1 check passed
@frostbyte73 frostbyte73 deleted the wrappers branch August 23, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants