skip aws logging on successful upload #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boks1971
approved these changes
Aug 26, 2024
boks1971
reviewed
Aug 26, 2024
That is probably a good idea. I have no idea how many logs they put out but it seems to be a lot |
| func (l *S3Logger) Log(args ...interface{}) { | ||
| msg := "aws sdk:" | ||
| for range len(args) { | ||
| msg += " %v" |
There was a problem hiding this comment.
Tin my experience, building log strings this way cause enough men copies that it can have a significant performance impact. strings.Builder should be more efficient
|
|
||
| l.mu.Lock() | ||
| if len(l.msgs) >= 10 { | ||
| l.msgs = append(l.msgs[1:], msg) |
There was a problem hiding this comment.
If my understanding of go slices is correct, this will cause the array backing to slice to grow indefinitely until the logger gets destroyed as the beginning of the array will never be reclaimed. We may want to either copy the leftover part of the slice to the beginning of the array, or use ring buffer implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.