Avoid recording room composite before video is decoded #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's likely to receive delta frames that are not decodable in the start. This would produce an undesirable black screen in the beginning of the recording.
|
This means we'll potentially cut some audio from the start of the recording, until a video becomes decodable. Is this always desirable? I can also see how a few customers may have a broken setup where they publish a video track but never send any video so we'd want to advertise this change pretty explicitly in the changelog. |
|
It's a tricky one for sure. these are the use cases:
before this PR, it doesn't satisfy 1, which is where users have been complaining about. For 2, we should move this to mixing within the process, instead of using templates for them.
|
biglittlebigben
approved these changes
Nov 14, 2024
frostbyte73
approved these changes
Nov 14, 2024
biglittlebigben
added a commit
that referenced
this pull request
Jan 6, 2025
## Changelog ### Added - Support for backup storage (#792) (#793) (#795) (#825) - Log per egress memory usage (#821) - Support for participant egress screen share (#829) - Use the SDK to handle audio only room composite requests with the default template (#817) ### Fixed - Skip AWS logging on successful upload (#762) - Reduce duplicate test runs (#763) - Fix s3logger memory usage (#764) - Disable SDK Async-connect (#768) - Faster startup (#769) - Queue 15 min worth of segments (#770) - Use config value for max upload queue size (#772) - Disable-features Translate in headless Chrome (#775) - Add a back off top laylist upload retries (#779) - Remove audio with image-only egress (#782) - Adopt AWS SDK v2 (#783) - Force CBR for streams output (#785) - Don't update bucket region with custom endpoints (#786) - Set a region field when using a custom endpoint (#788) - Ignore websocket close errors (#790) - Avoid recording room composite before video is decoded (#806) - Fix max concurrent web check (#810) - Use Ubuntu 24.04 base image (#811) - Move IO timeouts to config (#814) - Upgrade to pion/webrtc v4 (#818) - Kill highest memory egress when OOM (#826) - Udpate livekit JS dependencies and call setRoom in default template (#835)
Merged
biglittlebigben
added a commit
that referenced
this pull request
Jan 7, 2025
## Changelog ### Added - Support for backup storage (#792) (#793) (#795) (#825) - Log per egress memory usage (#821) - Support for participant egress screen share (#829) - Use the SDK to handle audio only room composite requests with the default template (#817) ### Fixed - Skip AWS logging on successful upload (#762) - Reduce duplicate test runs (#763) - Fix s3logger memory usage (#764) - Disable SDK Async-connect (#768) - Faster startup (#769) - Queue 15 min worth of segments (#770) - Use config value for max upload queue size (#772) - Disable-features Translate in headless Chrome (#775) - Add a back off top laylist upload retries (#779) - Remove audio with image-only egress (#782) - Adopt AWS SDK v2 (#783) - Force CBR for streams output (#785) - Don't update bucket region with custom endpoints (#786) - Set a region field when using a custom endpoint (#788) - Ignore websocket close errors (#790) - Avoid recording room composite before video is decoded (#806) - Fix max concurrent web check (#810) - Use Ubuntu 24.04 base image (#811) - Move IO timeouts to config (#814) - Upgrade to pion/webrtc v4 (#818) - Kill highest memory egress when OOM (#826) - Udpate livekit JS dependencies and call setRoom in default template (#835)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely to receive delta frames that are not decodable in the start. This would produce an undesirable black screen in the beginning of the recording.