Skip to content

Send SDK override and version to FFI #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 24, 2024
Merged

Send SDK override and version to FFI #305

merged 25 commits into from
Oct 24, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 17, 2024

Screenshot showing this coming out correctly in SFU logs:

image

This PR depends on these three PRs, all merged. Just waiting on FFI bump, but planning to do RPC at the same time.
livekit/rust-sdks#471
livekit/livekit#3110
https://github.com/livekit/cloud/pull/3083

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 1134766

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/rtc-node Patch
@livekit/rtc-node-darwin-arm64 Patch
@livekit/rtc-node-darwin-x64 Patch
@livekit/rtc-node-linux-arm64-gnu Patch
@livekit/rtc-node-linux-x64-gnu Patch
@livekit/rtc-node-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bcherry bcherry requested review from nbsp and theomonnom October 17, 2024 00:43
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome lgtm!

@bcherry
Copy link
Contributor Author

bcherry commented Oct 23, 2024

@nbsp maybe you can take a look at the way i'm getting the version. Originally I had it importing package.json directly at runtime but that didn't seem to work reliably so I have it now generating a file at build time. I guess ideally the changeset script would generate this file but I read the docs and couldn't find an obvious way to do that.

@nbsp
Copy link
Member

nbsp commented Oct 24, 2024

idea: add the version file to gitignore, generate it on build/release time on the same step it publishes to npm. that way it pulls in the version file at runtime without redundancy.

see how livekit/protocol JS directory doesn't have protobufs, but the npm package does.

@bcherry
Copy link
Contributor Author

bcherry commented Oct 24, 2024

@nbsp yeah good idea - that seems to work fine and will prevent weird local churn.

@bcherry bcherry merged commit fb0380c into main Oct 24, 2024
10 checks passed
@bcherry bcherry deleted the bcherry/sdk-version branch October 24, 2024 22:46
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants