-
Notifications
You must be signed in to change notification settings - Fork 80
Send SDK override and version to FFI #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1134766 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome lgtm!
@nbsp maybe you can take a look at the way i'm getting the version. Originally I had it importing package.json directly at runtime but that didn't seem to work reliably so I have it now generating a file at build time. I guess ideally the changeset script would generate this file but I read the docs and couldn't find an obvious way to do that. |
idea: add the version file to gitignore, generate it on build/release time on the same step it publishes to npm. that way it pulls in the version file at runtime without redundancy. see how livekit/protocol JS directory doesn't have protobufs, but the npm package does. |
@nbsp yeah good idea - that seems to work fine and will prevent weird local churn. |
Screenshot showing this coming out correctly in SFU logs:
This PR depends on these three PRs, all merged. Just waiting on FFI bump, but planning to do RPC at the same time.
livekit/rust-sdks#471
livekit/livekit#3110
https://github.com/livekit/cloud/pull/3083