Conversation
lukasIO
commented
Jan 29, 2025
Merged
lukasIO
changed the title
davidzhao
approved these changes
Jan 31, 2025
longcw
reviewed
Feb 1, 2025
Contributor
There was a problem hiding this comment.
should this warning be a debug or removed: https://github.com/livekit/python-sdks/pull/352/files#diff-e6d6a673948fca293a54c3930f2c95f3fec05cc33b6dc8c27935584da4529b17L802
Contributor
Author
There was a problem hiding this comment.
uff, thanks, that was a debug left over, removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses feedback from @theomonnom on #347 after it got merged