ffi: force VideoEncoding bitrate and framerate (#405)

livekit · Aug 23, 2024 · 6816a32 · 6816a32
1 parent 0465fec
commit 6816a32
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/livekit-ffi/Cargo.toml b/livekit-ffi/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "livekit-ffi"
-version = "0.8.1"
+version = "0.8.2"
 edition = "2021"
 license = "Apache-2.0"
 description = "FFI interface for bindings in other languages"

diff --git a/livekit-ffi/src/server/room.rs b/livekit-ffi/src/server/room.rs
@@ -403,6 +403,16 @@ impl RoomInner {
                 let track = LocalTrack::try_from(ffi_track.track.clone())
                     .map_err(|_| FfiError::InvalidRequest("track is not a LocalTrack".into()))?;
 
+                // protobuf 3 doesn't let us require fields, instead defaulting to zero.
+                if publish.options.clone().is_some_and(|opts| {
+                    opts.video_encoding
+                        .is_some_and(|enc| enc.max_framerate == 0.0 || enc.max_bitrate == 0)
+                }) {
+                    return Err(FfiError::InvalidRequest(
+                        "VideoEncoding must specify both max_framerate and max_bitrate".into(),
+                    ));
+                }
+
                 let publication = inner
                     .room
                     .local_participant()