Update README #236
Merged
Update README #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @davidzhao , do you mind if the "Receive video frames of a subscribed track" section of the README is also updated as part of this PR? The README doesn't show the current method of receiving video frames and can be a bit confusing to follow. possible update ( gotten from the wgpu_room example) let video_stream = NativeVideoStream::new(rtc_track);
while let Some(frame) = async_handle.block_on(video_sink.next()) {
....
let buffer = frame.buffer.to_i420();
.....
}I'm open to helping contribute to this PR or putting up a new one after this one is merged. |
|
@cs50victor yeah! I'd welcome your feedback here. Let me know if there's anything you think we should change. |
theomonnom
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.