Add metrics about face value and max float #3593
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3593 +/- ##
===================================================
+ Coverage 30.77611% 30.79303% +0.01692%
===================================================
Files 153 153
Lines 45870 45900 +30
===================================================
+ Hits 14117 14134 +17
- Misses 30930 30942 +12
- Partials 823 824 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| @@ -341,6 +343,8 @@ func InitCensus(nodeType NodeType, version string) { | |||
| census.mPaymentCreateError = stats.Int64("payment_create_errors", "PaymentCreateError", "tot") | |||
| census.mDeposit = stats.Float64("gateway_deposit", "Current remaining deposit for the gateway node", "gwei") | |||
| census.mReserve = stats.Float64("gateway_reserve", "Current remaining reserve for the gateway node", "gwei") | |||
| census.mMaxFloat = stats.Float64("gateway_max_float", "Last maximum float for the gateway node", "gwei") | |||
| census.mTicketFaceValue = stats.Float64("ticket_face_value", "Last ticket face value for the gateway node", "gwei") | |||
There was a problem hiding this comment.
I don't know much about maxFloat and ticketFace but I hope this is up to date - https://github.com/livepeer/go-livepeer/blob/master/doc/redeemer.md
There was a problem hiding this comment.
I think that is up to date but its for running go-livepeer as a -redeemer. The downside to this is that the redeemer then becomes the central failure point because the Orchestrator then depends on it to get maxFloat.
I have a PR removing the dependency on my fork of go-livepeer so the redeemer only accepts tickets sent from the Orchestrator if interested.
It's just for the sake of consistency. We have other metrics (deposit, reserve) in gwei as well. |
No description provided.