-
Couldn't load subscription status.
- Fork 203
BYOC: add streaming #3727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BYOC: add streaming #3727
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3727 +/- ##
===================================================
+ Coverage 31.52544% 32.88168% +1.35624%
===================================================
Files 159 160 +1
Lines 47901 40223 -7678
===================================================
- Hits 15101 13226 -1875
+ Misses 31911 25956 -5955
- Partials 889 1041 +152
... and 144 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fdc7fc4 to
34e53b9
Compare
| } | ||
| stopJob.sign() //no changes to make, sign job | ||
|
|
||
| token, err := sessionToToken(params.liveParams.sess) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets check/log this err here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still hoping we can check and log this err
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an error check and log in d73fe37. Note that this function cannot return an error currently, should I just update to only return the JobToken. I think I added an error here thinking as I built it out something could cause an error possibly.
e862a20 to
33fda51
Compare
…able live payments
* Add SDXL and SDXL FaceID streamdiffusion images Co-authored-by: victorgelias <victorgelias@gmail.com> * Refactor: Clarify docker image descriptions Co-authored-by: victorgelias <victorgelias@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…gateway->sendPaymentForStream
…5 segment history
ddf2612 to
1ca67c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After resolving conflicts, lets merge 👍
8146306 to
5962060
Compare
What does this pull request do? Explain your changes. (required)
Adds configurable streaming for BYOC entrypoint to go-livepeer. Uses trickle protocol to handle streaming for similar entrypoints and outputs from go-livepeer as live-video-to-video.
Streams can be any or a mix of the following:
Control and Events channels are created for every stream.
Streams are created with a POST request to
/ai/stream/startthat will start the stream and reserve the capacity with an Orchestrator that is providing the BYOC capability. If video ingress is enabled, the client should then start a stream with WHIP or RTMP to the provided ingress URLs provided in the response. URLs for egress video, data, updates (control) and events are also included in the response as well as the stream_id. The stream_id is an integral part of the URLs provided to interact with the stream and is combined with a provided stream name in the /ai/stream/start request.Streams are stopped with a POST request to
/ai/stream/stop. Orchestrators and Gateways track payment balance and the Gateway adjusts to the Orchestrators provided balance in new JobTokens provided at each payment interval every minute. Orchestrators will shutdown a stream when payment balance is zero.Specific updates (required)
job_stream.goandjob_stream_test.gojob_rpc.goto reuse stream setup where made sensecommon/testutil.go.How did you test each of these updates (required)
Used
byoc-streamto test end to end: https://github.com/ad-astra-video/livepeer-app-pipelines/tree/main/byoc-streamAdded tests to
job_stream_test.goand some additional tests tojob_rpc_test.go.Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass