-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Realtime Viewership API #185
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
===================================================
- Coverage 28.99628% 28.64721% -0.34907%
===================================================
Files 5 6 +1
Lines 269 377 +108
===================================================
+ Hits 78 108 +30
- Misses 180 256 +76
- Partials 11 13 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments that need to be addressed but can happen after merging if we need to get this into staging asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM either way but made a couple suggestions. The only higher-level issue I have is with the historical metrics being exposed on the same endpoint as the realtime metrics, as I think that can be confusing for using and maintaining this.
Co-authored-by: Victor Elias <victor@livepeer.org>
@ecmulli @victorges Thanks for all the comments. I addressed most of them. Planning to merge this PR and open the discussion in Discord. |
API Spec
Changes:
QuerySpec
parsing (to re-use in other APIs)fix https://linear.app/livepeer/issue/ENG-1652/implement-api-to-deliver-real-time-data