Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Realtime Viewership API into Now and Time Series APIs #186

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Mar 14, 2024

As discussed in Discord, we split /data/views/active API into two separate APIs:

  • /data/views/now
  • /data/views/internal/timeSeries

fix https://linear.app/livepeer/issue/ENG-1799/revisit-viewsactive-api

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 10.63830% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 28.57143%. Comparing base (3cf1819) to head (7f5de96).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #186         +/-   ##
===================================================
- Coverage   28.64721%   28.57143%   -0.07578%     
===================================================
  Files              6           6                 
  Lines            377         392         +15     
===================================================
+ Hits             108         112          +4     
- Misses           256         266         +10     
- Partials          13          14          +1     
Files Coverage Δ
views/client.go 21.48148% <71.42857%> (+2.10164%) ⬆️
views/clickhouse.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf1819...7f5de96. Read the comment docs.

Files Coverage Δ
views/client.go 21.48148% <71.42857%> (+2.10164%) ⬆️
views/clickhouse.go 0.00000% <0.00000%> (ø)

@leszko leszko marked this pull request as ready for review March 14, 2024 09:43
@leszko leszko requested a review from a team as a code owner March 14, 2024 09:43
Copy link

linear bot commented Mar 14, 2024

@leszko leszko requested review from victorges and ecmulli March 14, 2024 09:44
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leszko and others added 3 commits March 18, 2024 09:46
Co-authored-by: Evan Mullins <evancmullins@gmail.com>
Co-authored-by: Victor Elias <victor@livepeer.org>
@leszko leszko requested a review from ecmulli March 18, 2024 08:52
@leszko leszko merged commit e1c52d8 into main Mar 19, 2024
13 checks passed
@leszko leszko deleted the rafal/analytics-revisit-realtime-viewership-api branch March 19, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants