Fix HID read/write issue on Windows #11
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear ljakob,
First of all, thank you for your work on this repo. Your implementation has been extremely useful, and I truly appreciate the effort you've put into it.
While using
unit_ut61epluson Windows 10, I encountered an issue where:read()function blocks indefinitely, preventing further execution.After investigating, I found that this behavior is caused by how HIDAPI handles Report IDs on Windows:
hid_write()pads the buffer to 65 bytes, leading to incorrect return values.hid_read()is blocking by default in Windows, meaning it waits indefinitely if no data is available.Proposed Solution:
write()on Windows by prepending0x00if needed.read()to prevent infinite waits, and introduce a timeout to avoid unnecessary delays.I have implemented and tested these fixes, and they resolve the issue without affecting functionality on Linux.
You will see that I also changed the variables CP2110_VID and CP2110_PID, as this is how my USB is numbered.
Thanks again for your work! 🚀
Best regards,