Skip to content

Pass args to getId #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

cranberyxl
Copy link
Contributor

When calculating cursors, sometimes you need to know information like the type of index being used. Passing args through makes this possible

@riginoommen
Copy link
Collaborator

please update test cases also

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (98c566f) to head (264d0d4).
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   97.76%   94.96%   -2.81%     
==========================================
  Files          21       23       +2     
  Lines         358      417      +59     
  Branches       65       83      +18     
==========================================
+ Hits          350      396      +46     
- Misses          7       13       +6     
- Partials        1        8       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkrzyzanek
Copy link
Owner

Thank you very much @cranberyxl for your contribution!

@lkrzyzanek
Copy link
Owner

@cranberyxl could you please squash the commits with conventional commit message "feat: Pass args to getId function". Thank you!

@cranberyxl
Copy link
Contributor Author

@cranberyxl could you please squash the commits with conventional commit message "feat: Pass args to getId function". Thank you!

done

@lkrzyzanek
Copy link
Owner

Great. Merging.

@lkrzyzanek lkrzyzanek merged commit bdc397c into lkrzyzanek:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants