-
Notifications
You must be signed in to change notification settings - Fork 51
PR from fork/331 #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR from fork/331 #352
Conversation
…sts in the metadata.
…ce instead of per tuning
…ze into all kernels that contain boilerplate
and resolve merge conflicts
|
@michaelmckinsey1 I merged develop into this and resolved the merge conflicts. When checks pass, is this ready to merge? |
|
Done in 51144fb. Also, @daboehme wanted to cleanup the caliper implementation before the merge, so that will come soon. |
|
Sounds good. I review and get some others to also review when you're ready. Please let me know. |
|
rhornung67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments.
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
|
@michaelmckinsey1 do you have any documentation on how to run with caliper and view caliper reports? |
All of that is in the |
and resolve merge conflicts
|
@michaelmckinsey1 I merged develop into this. There were several merge conflicts in Executor.cpp that I resolved because I refactored Executor::setupSuite(). When you have time, please take a look to make sure I didn't screw up anything you did. When you are OK with it, I will merge it. Thank you. |
|
Hi @rhornung67, Michael is currently out of office for the beginning of the week as he makes his way home. He and I can take a final look next week at the latest. |
|
No worries. |
|
@rhornung67 Fixed and re-merged develop. |
Thanks for looking over @michaelmckinsey1 I will merge this when checks come back green. It may be a couple of days since our ruby platform is down sue to cooling issues. |
PR from #331 Integrate Caliper