Fix/test all cases for constant namescheme#515
Merged
markcmiller86 merged 20 commits into4.12RCfrom Feb 4, 2026
Merged
Conversation
cyrush
approved these changes
Feb 3, 2026
Member
cyrush
left a comment
There was a problem hiding this comment.
Confirming patch works for with Conduit use cases
Member
Author
|
Ok, thanks @cyrush. I put some other changes in this PR that were about fixing testing on macOS including some ASAN failures and CI artifact upload...related to the namescheme issue because I wasn't able to test and examine failures without those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes handling of constant nameschemes and adds several more test cases for them.
The critical code here is in commit 43a52d7. But I ran into several other things while creating that patch that are worth fixing here too.