Skip to content

Comments

Fix/test all cases for constant namescheme#515

Merged
markcmiller86 merged 20 commits into4.12RCfrom
bug-mcm86-23jan26-onechar-ns-delim
Feb 4, 2026
Merged

Fix/test all cases for constant namescheme#515
markcmiller86 merged 20 commits into4.12RCfrom
bug-mcm86-23jan26-onechar-ns-delim

Conversation

@markcmiller86
Copy link
Member

@markcmiller86 markcmiller86 commented Jan 24, 2026

This fixes handling of constant nameschemes and adds several more test cases for them.

The critical code here is in commit 43a52d7. But I ran into several other things while creating that patch that are worth fixing here too.

  • Since I was doing builds without HDF5 (didn't need it for this), I discovered some issues doing a PDB-only build and fixed those.
  • I updated the documentation regarding namescheme delimiter character and constant nameschemes.
  • I was doing the work on a mac and discovered some issues with running test suite on a mac involving rpath.
  • I fixed some issues with CI uploading failure artifacts and RC branch regex pattern matching.

@markcmiller86 markcmiller86 marked this pull request as ready for review January 24, 2026 05:31
Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming patch works for with Conduit use cases

@markcmiller86
Copy link
Member Author

Ok, thanks @cyrush. I put some other changes in this PR that were about fixing testing on macOS including some ASAN failures and CI artifact upload...related to the namescheme issue because I wasn't able to test and examine failures without those changes.

@markcmiller86 markcmiller86 merged commit 023ca72 into 4.12RC Feb 4, 2026
4 checks passed
@markcmiller86 markcmiller86 deleted the bug-mcm86-23jan26-onechar-ns-delim branch February 4, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants