Remove mpio vfd from default list processed by unknown driver#517
Open
markcmiller86 wants to merge 3 commits into4.12RCfrom
Open
Remove mpio vfd from default list processed by unknown driver#517markcmiller86 wants to merge 3 commits into4.12RCfrom
markcmiller86 wants to merge 3 commits into4.12RCfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has never been seen before because most people link Silo against serial HDF5 and/or do not use Silo's
DB_UNKNOWNdriver when opening some file.The combination of linking to a parallel-enabled HDF5 library and using Silo's
DB_UNKNOWNto open a file could lead to a seg-fault in MPI.Because Silo can be used with a variety of HDF5 virtual file drivers (vfd), when opening an "unknown" file, different vfds maybe to be tried (e.g. split, family, silo-block-based, etc.). This list also included HDF5's built-in MPIO vfd if the HDF5 Silo was linked to was enabled with parallel. This would eventually trigger
MPI_xxx()calls in the HDF5 library whenMPI_Init()had not been called.This PR fixes this problem. It also fixes some problems running tests on macOS. The key patch commit for the funky MPI behavior is 7cb7983