Fix some memory leaks #189
Merged
+10
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srwopschall
reviewed
Jan 23, 2026
|
|
||
| tribol::finalize(); | ||
|
|
||
| // delete the jacobian matrix |
Collaborator
There was a problem hiding this comment.
was jac not being used?
srwopschall
approved these changes
Jan 23, 2026
Collaborator
srwopschall
left a comment
srwopschall
left a comment
There was a problem hiding this comment.
@ebchin - Thanks for throwing this together. Everything looks good, just had some clarification comments so I follow.
| auto dfdx = cs->getMfemJacobianData()->GetMfemDfDxFullJacobian( *cs->getMethodData() ); | ||
| auto dfdn = cs->getMfemJacobianData()->GetMfemDfDnJacobian( *cs->getDfDnMethodData() ); | ||
| auto dndx = cs->getMfemJacobianData()->GetMfemDnDxJacobian( *cs->getDnDxMethodData() ); | ||
| auto dfdx_nconst = std::unique_ptr<mfem::HypreParMatrix>( |
Collaborator
There was a problem hiding this comment.
Just to confirm looks like you had a mult embedded in an add and here you just separate them?
| * \brief Destructor | ||
| */ | ||
| ~MethodData() {}; | ||
| virtual ~MethodData() {}; |
| ones.GetMemory().SetHostPtrOwner( false ); | ||
| inactive_sm.SetDataOwner( false ); | ||
| inactive_hpm->SetOwnerFlags( 3, 3, 1 ); | ||
| inactive_hpm->SetOwnerFlags( 3, inactive_hpm->OwnsOffd(), inactive_hpm->OwnsColMap() ); |
Collaborator
There was a problem hiding this comment.
Not familiar with this, but we can chat about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.