SNL sparta

[rfhaque]

This PR adds the Sparta application (docs: Adding a Benchmark)

• Not using develop, source code: Sparta build for AMD GPUs sparta/sparta#573
• Adding repo/sparta-snl/package.py to specify build
• Adding repo/sparta-snl/application.py to specify runtime parameters
• Adding experiments/sparta-snl/experiment.py to specify the experiment to run
• Sparta dry run is passing
• Add Sparta+openmp and Sparta+rocm to gitlab CI on Dane and Tuo or Tioga -- see Make Alternate Workload Nightly Tests for Lammps and AMG #1111
• Update the package to meet Spack 1.0 requirements @scheibelp

[pearce8]

• Sparta dry run should be passing
• Add Sparta+openmp and Sparta+rocm to CI on Dane and Tuo or Tioga
• Since this will likely go in after the Spack 1.0 support, please update the package to meet Spack 1.0 requirements.

[scheibelp]

(this looks compatible with #953)

[pearce8]

@michaelmckinsey1 What do you mean by "Sparta needs a different version of rocm"?

[michaelmckinsey1]

That's not what this is saying. This benchmark can not be defined the same as the other rocm benchmarks because it requires a specific variant when running with rocm, i.e. fft_kokkos=hipfft. That is why I was thinking this is bad practice to encode this variant in the experiment. I was thinking this is something you would set in the package.py, like depends_on("hipfft", when="rocm"), but after discussing with @scheibelp and @rfhaque yesterday I'm not sure it's so simple.

[pearce8]

@scheibelp we need help with this

[pearce8]

g should probably be 1 -- or n_gpus/m_gpus_per_node

[michaelmckinsey1]

FYI This is to fix dryrun error where this particular experiment is generated asking for too many cores for these particular systems.

[pearce8]

@michaelmckinsey1 do you know why lint is failing?

[michaelmckinsey1]

It says [+] Would fix .gitlab/tests/shared_flux_clusters.yml

[michaelmckinsey1]

@pearce8 That lint failure requires yamlfix .gitlab/tests/shared_flux_clusters.yml. I have fixed it. I think #1116 will address when to run certain linter commands in the future

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.44%. Comparing base (d5e099c) to head (a36561a).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1033      +/-   ##
===========================================
+ Coverage    65.31%   65.44%   +0.12%     
===========================================
  Files           44       44              
  Lines         3241     3241              
  Branches       256      256              
===========================================
+ Hits          2117     2121       +4     
+ Misses        1117     1113       -4     
  Partials         7        7              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.