Skip to content

Conversation

@simongdg
Copy link
Contributor

@simongdg simongdg commented Sep 9, 2025

Adding El Dorado system (docs: Adding a System)

  • Add systems/snl-eldorado/system.py file - only if it is different from El Capitan software stack
  • Should be able to use El Capitan's systems/all_hardware_descriptions/hardware_name/hardware_description.yaml which will appear in the docs catalogue
  • Update system.py to use Spack 1.0 @scheibelp

Adding Commbench benchmark (docs: Adding a Benchmark)

  • package.py
  • update package.py to use Spack 1.0 @scheibelp
  • application.py
  • Tags in Ramble's application.py or in repo/benchmark_name/application.py will appear in the docs catalogue
  • Add experiment.py to define a single node and multi-node experiments

@github-actions github-actions bot added experiment New or modified experiment system New or modified system config application labels Sep 9, 2025
@pearce8 pearce8 requested a review from nhanford September 10, 2025 19:36
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears similar to https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py, so I added some references about what needs to change with the merge of #953

(package recipe looks compatible, no notes there)

if self.spec.satisfies("compiler=cce") or self.spec.satisfies(
"compiler=rocmcc"
):
selections["compilers"] += self.rocm_cce_compiler_cfg()["compilers"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specification for this changed: it looks like https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py is a close match (uses all the same compilers). If you have questions about that, let me know.

@nhanford nhanford mentioned this pull request Oct 6, 2025
20 tasks
@simongdg
Copy link
Contributor Author

I have updated my pull request so that the snl-eldorado system looks more similar to llnl-elcapitan system. I also undid the cray-mpich package.py to how it was originally, as I was able to add the gtl_lib_path to my snl-eldorado system.py.

@pearce8 pearce8 merged commit 3e811c3 into llnl:develop Oct 27, 2025
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application experiment New or modified experiment system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants