-
Notifications
You must be signed in to change notification settings - Fork 42
Adding support for Commbench as a new experiment, also adding El Dorado as a system #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scheibelp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears similar to https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py, so I added some references about what needs to change with the merge of #953
(package recipe looks compatible, no notes there)
systems/snl-eldorado/system.py
Outdated
| if self.spec.satisfies("compiler=cce") or self.spec.satisfies( | ||
| "compiler=rocmcc" | ||
| ): | ||
| selections["compilers"] += self.rocm_cce_compiler_cfg()["compilers"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification for this changed: it looks like https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py is a close match (uses all the same compilers). If you have questions about that, let me know.
… it was before I modified it
|
I have updated my pull request so that the snl-eldorado system looks more similar to llnl-elcapitan system. I also undid the cray-mpich package.py to how it was originally, as I was able to add the gtl_lib_path to my snl-eldorado system.py. |
Adding El Dorado system (docs: Adding a System)
systems/snl-eldorado/system.pyfile - only if it is different from El Capitan software stacksystems/all_hardware_descriptions/hardware_name/hardware_description.yamlwhich will appear in the docs catalogueAdding Commbench benchmark (docs: Adding a Benchmark)
application.pyor inrepo/benchmark_name/application.pywill appear in the docs catalogue